Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support nftables for Debian 11 #179

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix: Support nftables for Debian 11 #179

merged 1 commit into from
Feb 18, 2022

Conversation

eaglesemanation
Copy link
Contributor

@eaglesemanation eaglesemanation commented Feb 15, 2022 •
edited
Loading

Support nftables for Debian 11

Summary

Since v1.22.3+k3s1 nftables is supported by k3s according to this comment: k3s-io/k3s#4188 (comment)
Also fixed silly mistake in version check

Issue type

  • Bugfix

Test instructions

Deployed cluster of 1 controller and 2 workers on Vagrant. On resulting cluster deployed following DaemonSet:

apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: ubuntu-debug
spec:
  selector:
    matchLabels:
      name: ubuntu-debug
  template:
    metadata:
      labels:
        name: ubuntu-debug
    spec:
      tolerations:
      - key: node-role.kubernetes.io/master
        operator: Exists
        effect: NoSchedule
      containers:
      - name: ubuntu-debug
        image: docker.io/library/ubuntu:latest
        command: ['sleep', '3600']

Then connected to one of the workers and successfully managed to ping pods on other nodes.

Acceptance Criteria

Additional Information

@xanmanning xanmanning self-assigned this Feb 16, 2022
@xanmanning xanmanning added the bug Something isn't working label Feb 16, 2022
xanmanning
xanmanning approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@xanmanning xanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers 🍻

@xanmanning xanmanning merged commit 4387b3d into PyratLabs:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xanmanning xanmanning xanmanning approved these changes

Assignees

@xanmanning xanmanning

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaglesemanation @xanmanning